Arrogant peer code reviewer

Sometimes, code review can become an adversarial activity so you must think in terms of your goals. Code review is supposed to help with quality code and sharing knowledge. Some people like to mentor and teach and others wield. This is what you can do when the feedback is poorly delivered:

  • If the feedback was helpful go ahead and improve yourself.
  • If the feedback doesn’t bring any improvement ask the reviewer to behave differently but don’t involve management directly about these interpersonal differences. Indirectly, ask other code reviewers, work on a different project, transfer.
  • Demonstrate him he is wrong by citing industry expert quotes, bringing books, websites, case studies.

Being « passionate » is not an excuse to treat you poorly, writing software should be fun.